Remove deprecated startSpan and use integration name for telemetry#11181
Draft
Remove deprecated startSpan and use integration name for telemetry#11181
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055188
Total [baseline] (8.871 s) : 0, 8870556
Agent [candidate] (1.05 s) : 0, 1050410
Total [candidate] (8.823 s) : 0, 8823190
section iast
Agent [baseline] (1.24 s) : 0, 1240470
Total [baseline] (9.581 s) : 0, 9581304
Agent [candidate] (1.241 s) : 0, 1240914
Total [candidate] (9.544 s) : 0, 9543612
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (632.638 ms) : 0, 632638
BytebuddyAgent [candidate] (632.334 ms) : 0, 632334
AgentMeter [baseline] (29.588 ms) : 0, 29588
AgentMeter [candidate] (29.456 ms) : 0, 29456
GlobalTracer [baseline] (249.848 ms) : 0, 249848
GlobalTracer [candidate] (247.779 ms) : 0, 247779
AppSec [baseline] (32.658 ms) : 0, 32658
AppSec [candidate] (32.032 ms) : 0, 32032
Debugger [baseline] (59.31 ms) : 0, 59310
Debugger [candidate] (58.657 ms) : 0, 58657
Remote Config [baseline] (597.091 µs) : 0, 597
Remote Config [candidate] (583.997 µs) : 0, 584
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (8.717 ms) : 0, 8717
Flare Poller [baseline] (4.381 ms) : 0, 4381
Flare Poller [candidate] (3.509 ms) : 0, 3509
section iast
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (815.169 ms) : 0, 815169
BytebuddyAgent [candidate] (816.555 ms) : 0, 816555
AgentMeter [baseline] (11.647 ms) : 0, 11647
AgentMeter [candidate] (11.529 ms) : 0, 11529
GlobalTracer [baseline] (240.131 ms) : 0, 240131
GlobalTracer [candidate] (240.243 ms) : 0, 240243
AppSec [baseline] (29.138 ms) : 0, 29138
AppSec [candidate] (30.44 ms) : 0, 30440
Debugger [baseline] (68.878 ms) : 0, 68878
Debugger [candidate] (63.613 ms) : 0, 63613
Remote Config [baseline] (553.949 µs) : 0, 554
Remote Config [candidate] (541.98 µs) : 0, 542
Telemetry [baseline] (7.916 ms) : 0, 7916
Telemetry [candidate] (7.815 ms) : 0, 7815
Flare Poller [baseline] (3.504 ms) : 0, 3504
Flare Poller [candidate] (3.475 ms) : 0, 3475
IAST [baseline] (26.021 ms) : 0, 26021
IAST [candidate] (29.25 ms) : 0, 29250
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058651
Total [baseline] (11.062 s) : 0, 11061774
Agent [candidate] (1.056 s) : 0, 1056294
Total [candidate] (11.076 s) : 0, 11075699
section appsec
Agent [baseline] (1.276 s) : 0, 1275709
Total [baseline] (11.095 s) : 0, 11095403
Agent [candidate] (1.266 s) : 0, 1265548
Total [candidate] (11.138 s) : 0, 11138175
section iast
Agent [baseline] (1.241 s) : 0, 1240941
Total [baseline] (11.422 s) : 0, 11422052
Agent [candidate] (1.241 s) : 0, 1240874
Total [candidate] (11.345 s) : 0, 11345421
section profiling
Agent [baseline] (1.185 s) : 0, 1184937
Total [baseline] (11.041 s) : 0, 11041077
Agent [candidate] (1.188 s) : 0, 1188007
Total [candidate] (11.024 s) : 0, 11023890
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.274 ms) : 0, 1274
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (636.077 ms) : 0, 636077
BytebuddyAgent [candidate] (634.089 ms) : 0, 634089
AgentMeter [baseline] (29.516 ms) : 0, 29516
AgentMeter [candidate] (29.73 ms) : 0, 29730
GlobalTracer [baseline] (249.486 ms) : 0, 249486
GlobalTracer [candidate] (248.912 ms) : 0, 248912
AppSec [baseline] (32.305 ms) : 0, 32305
AppSec [candidate] (32.28 ms) : 0, 32280
Debugger [baseline] (59.894 ms) : 0, 59894
Debugger [candidate] (59.902 ms) : 0, 59902
Remote Config [baseline] (597.617 µs) : 0, 598
Remote Config [candidate] (595.637 µs) : 0, 596
Telemetry [baseline] (8.819 ms) : 0, 8819
Telemetry [candidate] (8.041 ms) : 0, 8041
Flare Poller [baseline] (4.378 ms) : 0, 4378
Flare Poller [candidate] (5.115 ms) : 0, 5115
section appsec
crashtracking [baseline] (1.261 ms) : 0, 1261
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (683.546 ms) : 0, 683546
BytebuddyAgent [candidate] (675.881 ms) : 0, 675881
AgentMeter [baseline] (12.308 ms) : 0, 12308
AgentMeter [candidate] (12.298 ms) : 0, 12298
GlobalTracer [baseline] (250.92 ms) : 0, 250920
GlobalTracer [candidate] (250.068 ms) : 0, 250068
AppSec [baseline] (187.376 ms) : 0, 187376
AppSec [candidate] (187.17 ms) : 0, 187170
Debugger [baseline] (66.954 ms) : 0, 66954
Debugger [candidate] (66.174 ms) : 0, 66174
Remote Config [baseline] (592.755 µs) : 0, 593
Remote Config [candidate] (581.157 µs) : 0, 581
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (7.94 ms) : 0, 7940
Flare Poller [baseline] (3.605 ms) : 0, 3605
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (24.398 ms) : 0, 24398
IAST [candidate] (24.242 ms) : 0, 24242
section iast
crashtracking [baseline] (1.246 ms) : 0, 1246
crashtracking [candidate] (1.236 ms) : 0, 1236
BytebuddyAgent [baseline] (815.149 ms) : 0, 815149
BytebuddyAgent [candidate] (816.255 ms) : 0, 816255
AgentMeter [baseline] (11.69 ms) : 0, 11690
AgentMeter [candidate] (11.55 ms) : 0, 11550
GlobalTracer [baseline] (240.479 ms) : 0, 240479
GlobalTracer [candidate] (240.341 ms) : 0, 240341
AppSec [baseline] (28.619 ms) : 0, 28619
AppSec [candidate] (25.877 ms) : 0, 25877
Debugger [baseline] (64.828 ms) : 0, 64828
Debugger [candidate] (66.792 ms) : 0, 66792
Remote Config [baseline] (538.075 µs) : 0, 538
Remote Config [candidate] (534.055 µs) : 0, 534
Telemetry [baseline] (7.777 ms) : 0, 7777
Telemetry [candidate] (7.765 ms) : 0, 7765
Flare Poller [baseline] (3.396 ms) : 0, 3396
Flare Poller [candidate] (3.379 ms) : 0, 3379
IAST [baseline] (31.118 ms) : 0, 31118
IAST [candidate] (30.958 ms) : 0, 30958
section profiling
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (692.125 ms) : 0, 692125
BytebuddyAgent [candidate] (693.841 ms) : 0, 693841
AgentMeter [baseline] (8.926 ms) : 0, 8926
AgentMeter [candidate] (9.058 ms) : 0, 9058
GlobalTracer [baseline] (207.544 ms) : 0, 207544
GlobalTracer [candidate] (208.025 ms) : 0, 208025
AppSec [baseline] (32.532 ms) : 0, 32532
AppSec [candidate] (32.625 ms) : 0, 32625
Debugger [baseline] (65.518 ms) : 0, 65518
Debugger [candidate] (65.652 ms) : 0, 65652
Remote Config [baseline] (586.249 µs) : 0, 586
Remote Config [candidate] (579.3 µs) : 0, 579
Telemetry [baseline] (7.846 ms) : 0, 7846
Telemetry [candidate] (7.787 ms) : 0, 7787
Flare Poller [baseline] (3.494 ms) : 0, 3494
Flare Poller [candidate] (3.495 ms) : 0, 3495
ProfilingAgent [baseline] (93.622 ms) : 0, 93622
ProfilingAgent [candidate] (93.651 ms) : 0, 93651
Profiling [baseline] (94.187 ms) : 0, 94187
Profiling [candidate] (94.217 ms) : 0, 94217
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (19.494 ms) : 19294, 19694
. : milestone, 19494,
appsec (18.55 ms) : 18365, 18734
. : milestone, 18550,
code_origins (17.92 ms) : 17742, 18098
. : milestone, 17920,
iast (17.857 ms) : 17681, 18032
. : milestone, 17857,
profiling (18.004 ms) : 17826, 18182
. : milestone, 18004,
tracing (17.805 ms) : 17627, 17984
. : milestone, 17805,
section candidate
no_agent (17.911 ms) : 17729, 18093
. : milestone, 17911,
appsec (19.999 ms) : 19794, 20203
. : milestone, 19999,
code_origins (17.717 ms) : 17542, 17892
. : milestone, 17717,
iast (17.911 ms) : 17732, 18091
. : milestone, 17911,
profiling (18.247 ms) : 18064, 18429
. : milestone, 18247,
tracing (17.585 ms) : 17411, 17759
. : milestone, 17585,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.246 ms) : 1233, 1258
. : milestone, 1246,
iast (3.202 ms) : 3158, 3245
. : milestone, 3202,
iast_FULL (5.971 ms) : 5912, 6031
. : milestone, 5971,
iast_GLOBAL (3.731 ms) : 3666, 3796
. : milestone, 3731,
profiling (2.065 ms) : 2047, 2084
. : milestone, 2065,
tracing (1.921 ms) : 1904, 1938
. : milestone, 1921,
section candidate
no_agent (1.257 ms) : 1244, 1269
. : milestone, 1257,
iast (3.206 ms) : 3163, 3248
. : milestone, 3206,
iast_FULL (5.978 ms) : 5917, 6038
. : milestone, 5978,
iast_GLOBAL (3.665 ms) : 3606, 3725
. : milestone, 3665,
profiling (2.266 ms) : 2244, 2289
. : milestone, 2266,
tracing (1.873 ms) : 1858, 1888
. : milestone, 1873,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1489
. : milestone, 1478,
appsec (3.851 ms) : 3628, 4074
. : milestone, 3851,
iast (2.273 ms) : 2204, 2343
. : milestone, 2273,
iast_GLOBAL (2.329 ms) : 2259, 2400
. : milestone, 2329,
profiling (2.097 ms) : 2042, 2152
. : milestone, 2097,
tracing (2.079 ms) : 2025, 2132
. : milestone, 2079,
section candidate
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (3.834 ms) : 3610, 4058
. : milestone, 3834,
iast (2.28 ms) : 2210, 2350
. : milestone, 2280,
iast_GLOBAL (2.324 ms) : 2254, 2394
. : milestone, 2324,
profiling (2.095 ms) : 2040, 2149
. : milestone, 2095,
tracing (2.1 ms) : 2046, 2154
. : milestone, 2100,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~fe1be817a6, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (15.542 s) : 15542000, 15542000
. : milestone, 15542000,
appsec (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
iast (18.497 s) : 18497000, 18497000
. : milestone, 18497000,
iast_GLOBAL (17.992 s) : 17992000, 17992000
. : milestone, 17992000,
profiling (15.809 s) : 15809000, 15809000
. : milestone, 15809000,
tracing (15.368 s) : 15368000, 15368000
. : milestone, 15368000,
section candidate
no_agent (15.712 s) : 15712000, 15712000
. : milestone, 15712000,
appsec (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
iast (18.785 s) : 18785000, 18785000
. : milestone, 18785000,
iast_GLOBAL (17.45 s) : 17450000, 17450000
. : milestone, 17450000,
profiling (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
tracing (15.065 s) : 15065000, 15065000
. : milestone, 15065000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
be63ca7 to
abab0a5
Compare
abab0a5 to
d069edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the 4 deprecated
startSpanoverloads fromAgentTracerthat accepted aCharSequencespan name as the only/first argument and defaulted to"datadog"as the instrumentation name:All ~145 call sites across ~143 instrumentation files have been migrated to the non-deprecated form that explicitly passes the integration's own name as the first
Stringargument (matchinginstrumentationNames()[0]from the nearest decorator). This ensures spans are attributed to the correct integration rather than the generic"datadog"default.The private
DEFAULT_INSTRUMENTATION_NAME = "datadog"constant inAgentTraceris also removed; the two remaining deprecated methods inTracerAPI(buildSpan(CharSequence)andsingleSpanBuilder(CharSequence)) now inline the"datadog"literal directly.No behaviour change — this is a pure refactor. The instrumentation name passed to the tracer now matches what each integration already declared as its own name.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.